Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable full MacOS build as part of CI #2346

Merged
merged 33 commits into from
Mar 28, 2022
Merged

Enable full MacOS build as part of CI #2346

merged 33 commits into from
Mar 28, 2022

Conversation

heplesser
Copy link
Contributor

This PR fixes issues with the CI setup for macOS, so that we can run the full testsuite for macOS (except MUSIC, libneurosim, Sionlib). To achieve this, Boost-installation is done via apt/brew now.

heplesser and others added 30 commits March 9, 2022 13:28
@heplesser
Activating FULL Github actions build under macOS
9a3931e
@heplesser
Set FULL_NEXT_EXTERNAL for macOS
4246122
@lekshmideepu
adding MacOS full build and some debugging lines in the testsuite
61d21f3
@lekshmideepu
testing
1cb42f0
@lekshmideepu
syntax fix..
af65079
@lekshmideepu
testing continues...
2dfc7df
@lekshmideepu
testing continues.....
058ebf0
@lekshmideepu
syntax fixing...
826f2d1
@lekshmideepu
syntax fixing.....
9be788e
@lekshmideepu
pip listing
3cf0990
@lekshmideepu
using specific versions of pytest and xdist
fae9a25
@lekshmideepu
echoing the PATH
0814e04
@lekshmideepu
getting the location of pip packages
f478d05
@lekshmideepu
adding the pip packge path to PATH
161af9b
@heplesser
Merge branch 'macos-full' of git@github.com:lekshmideepu/nest-simulat…
a053da2 
…or.git into macos-full-build
@heplesser
More debug output for mac build
61fbe95
@heplesser
Fixed formatting.
2392fe9
@heplesser
More debugging
9311432
@heplesser
For debugging, force do_test run at end of configuration and add extra
7061329 
test output. Remove all jobs except macos.
@heplesser
Run make installcheck after cmake to debug pytest problems.
9b8c878
@heplesser
Post-build installcheck, now verbose
1f6b0de
@heplesser
Testing explicit python
e41d96e
@heplesser
Trying to guide cmake to correct python.
4bf563e
@heplesser
Cleaning up for proper test.
7ab89cd
@heplesser
Restore full build matrix.
5e6b906
@heplesser
Merge branch 'master' of git@github.com:nest/nest-simulator.git into …
bd1fa8a 
…macos-full-build
@heplesser
Removed debug output.
2699405
@heplesser
Switch mac build again to full no external
b494f96
@heplesser
Add libomp to mac setup (again)
0e035cd
@heplesser
Install boost via brew, include MPI in full no external
65ce0cc
@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 17, 2022
@heplesser heplesser added this to In progress in Automated testing via automation Mar 17, 2022
gtrensch
gtrensch approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍 Thanks for this contribution.

Automated testing automation moved this from In progress to Reviewer approved Mar 28, 2022
lekshmideepu
lekshmideepu approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@lekshmideepu lekshmideepu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me as well 👍

@lekshmideepu lekshmideepu merged commit eb86acf into nest:master Mar 28, 2022
Automated testing automation moved this from Reviewer approved to Done Mar 28, 2022
@heplesser heplesser deleted the macos-full-build branch April 20, 2022 11:47
@gtrensch gtrensch changed the title Enable full macOS build as part of CI Enable full MacOS build as part of CI Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lekshmideepu lekshmideepu lekshmideepu approved these changes

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
No open projects
Automated testing
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @lekshmideepu @gtrensch