Fix clang 13 pedantic warnings #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
S: Normal
pnbabu
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings emitted by Clang 13 when run with
-pedantic -Wextra -Woverloaded-virtual -Wno-unknown-pragmas -Wall. Almost all of the warnings point out that defining a copy constructor without an assignment operator is deprecated (see also https://stackoverflow.com/questions/51863588/warning-definition-of-implicit-copy-constructor-is-deprecated).Note that building pynestkernel will issue lot's of warnings. This is Cython problem and reported there (cython/cython#4687).
@poojanbabu This may also be relevant for NESTML code generation, therefore I assign you as reviewer.