Update review guidelines #2352
Merged
Update review guidelines #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jougs
added
T: Enhancement
jessica-mitchell
requested changes
Mar 18, 2022
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
jougs
commented
Mar 23, 2022
jessica-mitchell
approved these changes
Mar 23, 2022
heplesser
requested changes
Apr 19, 2022
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
|
@heplesser: I've merged your suggestions. Can you please re-review/merge? Thanks! |
heplesser
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the review guidelines based on observations by @terhorstd and me during the release making process. This should also be discussed regularly during hackathons.