Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CMAKE_INSTALL_PREFIX from default MacOS install instructions #2355

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Mar 22, 2022

The default install instructions on Mac still recommended a CMAKE_INSTALL_PREFIX by default. This has certain drawbacks for beginners and has been deprecated in favor of a prefixless approach which installs into the active python env. I've swapped it with instructions for the prefixless approach.

@Helveg Helveg changed the title Removed CMAKE_INSTALL_PREFIX from recommended flow Removed CMAKE_INSTALL_PREFIX from default mac install instructions Mar 22, 2022
@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 23, 2022
@heplesser heplesser added this to In progress in Documentation via automation Mar 23, 2022
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor suggestion for a title, but since its a small change I will still approve the PR. Thanks!

doc/userdoc/installation/mac_install.rst Outdated Show resolved Hide resolved
doc/userdoc/installation/mac_install.rst Outdated Show resolved Hide resolved
Documentation automation moved this from In progress to Review Mar 23, 2022
Helveg and others added 2 commits March 24, 2022 09:46
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@heplesser heplesser merged commit f723b0a into nest:master Mar 28, 2022
Documentation automation moved this from Review to Done Mar 28, 2022
@Helveg Helveg deleted the mac-install-cmake-prefix branch March 28, 2022 10:10
@terhorstd terhorstd changed the title Removed CMAKE_INSTALL_PREFIX from default mac install instructions Removed CMAKE_INSTALL_PREFIX from default mac install instructions Jul 20, 2022
@terhorstd terhorstd changed the title Removed CMAKE_INSTALL_PREFIX from default mac install instructions Removed CMAKE_INSTALL_PREFIX from default MacOS install instructions Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants