-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GIF / GLIF acronyms to model title in documentation #2365
Conversation
Thank you for the PR. This is just an unfortunate naming clash (or almost-clash, GIF vs. GLIF). Both models are leaky (virtually all models in neuroscience are leaky, so I would not make a separate tag for this). If we want to disambiguate further, perhaps we could include the authors' (or first author's) name in the model name; or "Allen Institute" for GLIF. |
OK thanks @clinssen I kind of thought it was common, but was just going based on name :D. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessica-mitchell I added suggestions for slightly changed wording.
@diesmann @abigailm I'd much appreciate your comments on what would be the optimal way to make the source and thus nature of the GIF and GLIF models obvious to reduce the risk of confusion.
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
To help alleviate confusion between the two types of models, I've added the acronyms to the titles in the model userdocs section.
Not sure if further differentiation would be helpful (e.g., do we need to add a tag for leaky models?). @heplesser @diesmann perhaps have ideas.