Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report actual number of synapse created in PyNEST Brunel examples #2374

Merged
merged 7 commits into from
Aug 18, 2022

Conversation

heplesser
Copy link
Contributor

This PR ensures that PyNEST examples of Brunel networks report the actual number of excitatory and inhibitory connections created. Previously, the actual total number of synapses was reported, while the expected number was reported for excitatory and inhibitory synapses.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) good first issue Good for newcomers labels Apr 20, 2022
@heplesser heplesser added this to In progress in PyNEST via automation Apr 20, 2022
@clinssen
Copy link
Contributor

Question: is CE * N_neurons always precisely equal to nest.GetDefaults("excitatory")["num_connections"] (both of type int)?

@heplesser
Copy link
Contributor Author

Question: is CE * N_neurons always precisely equal to nest.GetDefaults("excitatory")["num_connections"] (both of type int)?

If the script is correct and NEST works correctly, then the following excitatory synapses should be created:

  • CE * N_neurons synapses from excitatory neurons to neurons (E and I)
  • N_neurons synapses from the poisson generator to neurons (E and I)
  • 2 * N_rec synapses from the recorded E and I neurons to the respective spike recorders

Furthermore CI * N_neurons synapses of type inhibitory should be created from inhibitory neurons to neurons (E and I).

So the old numbers E-synapse numbers were not quite correct, since they ignored the connections to the recorders, and the sums did not work out correctly.

I think it makes most sense to obtain the total number of synapses and the E/I numbers in the same way to ensure consistency—either expected numbers or measured. I propose to use the measured numbers in this PR.

@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jun 21, 2022
@terhorstd terhorstd added the need reviewer Ready to be reviewed but no reviewer assigned label Aug 2, 2022
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@heplesser heplesser merged commit a279113 into nest:master Aug 18, 2022
PyNEST automation moved this from In progress to Done Aug 18, 2022
@heplesser heplesser deleted the better_brunel_syn_count branch October 4, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) need reviewer Ready to be reviewed but no reviewer assigned S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants