Deprecate spike_dilutor and prohibit its use with multiple threads
#2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with threads. Use with threads is now prevented by a check.
heplesser
added
T: Bug
hakonsbm
suggested changes
Apr 21, 2022
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
…lator.git into fix-2052-dilutor
|
@heplesser: can you please fix the conflicts? Thanks! |
…fix-2052-dilutor Conflicts: doc/userdoc/release_notes/index.rst doc/userdoc/release_notes/v3.1/index.rst
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
terhorstd
changed the title
spike_dilutor and prohibit its use with multiple threads
resolved conflict
gtrensch
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spike_dilutoris a variant of a parrot neuron which probabilistically forwards spikes. Each target neuron receives a different thinned spike train. Therefore,spike_dilutorneeds to sendDSSpikeEvents and is implemented as aStimulationDevice. This conflicts, though, with the fact that the node also needs to receive spikes, leading to incorrect behavior when used with multiple threads (#2052).At the same time,
bernoulli_synapseimplements exactly the same functionality in a proper, i.e., synapse, not pseudo-neuron, based way. This PR thereforespike_dilutorspike_dilutorwith multiple threadsbernoulli_synapseas alternative.This fixes #2052.