Mark MPI as required if explicitly requested during CMake configuration #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonsbm
added
S: Normal
gtrensch
approved these changes
May 23, 2022
jougs
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During CMake configuration, if MPI is explicitly requested (with
-Dwith-mpi=ON), MPI is set asREQUIREDwhich makes CMake error if MPI is not found. Previously CMake would continue, and NEST would be installed without MPI support (this may be loosely related to #2381).Furthermore, if
with-mpiis passed a path, it is not used to find MPI as indicated by the documentation. There are no good ways to select an MPI installation based on the path alone, and this is a corner-case anyway, so the related text in the documentation is instead removed.