Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion from IntegerDatum to ConstantParameter in create_parameter() #2403

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Add conversion from IntegerDatum to ConstantParameter in create_parameter() #2403

merged 3 commits into from
Oct 20, 2022

Conversation

hakonsbm
Copy link
Contributor

Fixes #2399.

@hakonsbm hakonsbm added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 23, 2022
@hakonsbm hakonsbm added this to PRs in progress in Kernel via automation May 23, 2022
@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jul 23, 2022
@babsey
Copy link
Contributor

babsey commented Jul 25, 2022

Friendly ping. Any updates on this? 😳

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Jul 26, 2022
@terhorstd terhorstd added the need reviewer Ready to be reviewed but no reviewer assigned label Aug 2, 2022
@terhorstd terhorstd requested a review from babsey August 2, 2022 07:28
@terhorstd
Copy link
Contributor

@babsey, do you have time to check if this solves the linked issue for you? I added you as a first reviewer, but we need to find a second one before this can go in.

nicolossus
nicolossus suggested changes Aug 18, 2022
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in general but check ConstantParameter constructor for consistency with construction from dictionary w.r.t. returns_int_only_.

Kernel automation moved this from PRs in progress to PRs pending approval Aug 18, 2022
nicolossus
nicolossus approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Oct 19, 2022
babsey
babsey approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@babsey babsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. The linked issue was fixed.

LGTM!

@heplesser heplesser merged commit d4a055d into nest:master Oct 20, 2022
Kernel automation moved this from PRs pending approval to Done (PRs and issues) Oct 20, 2022
@hakonsbm hakonsbm deleted the spatial_integer_parameter branch October 20, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsey babsey babsey approved these changes

@nicolossus nicolossus nicolossus approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) need reviewer Ready to be reviewed but no reviewer assigned S: High Should be handled next stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter in ConnectLayers doesn't accept integer.
5 participants
@hakonsbm @babsey @terhorstd @nicolossus @heplesser