Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose prepared flag via kernel status dictionary #2408

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Jun 3, 2022

In a discussion with developers of the NEST-Desktop and Neurorobotics Platform (NRP), we found that both tools require to know if prepare() was already called or not. This is internally tracked, but was not available in the kernel status dictionary. This PR just exposes the bool flag to the API layers.

@jougs jougs requested review from babsey and terhorstd June 3, 2022 13:00
@terhorstd terhorstd added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: External API Developers of extensions or other language bindings may need to adapt their code labels Jun 7, 2022
@terhorstd terhorstd changed the title Expose prepared flag via kernel status dictionary Expose prepared flag via kernel status dictionary Jun 7, 2022
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jougs jougs self-assigned this Jun 8, 2022
@jougs jougs added this to PRs in progress in Kernel via automation Jun 8, 2022
@jougs
Copy link
Contributor Author

jougs commented Jun 8, 2022

Merging with single review, as this is only adding a feature and apparently does not break anything.

@jougs jougs merged commit e0f8991 into nest:master Jun 8, 2022
Kernel automation moved this from PRs in progress to Done (PRs and issues) Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: External API Developers of extensions or other language bindings may need to adapt their code S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Kernel
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants