Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change assertEqual to assertAlmostEqual in node parametrization tests #2423

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Change assertEqual to assertAlmostEqual in node parametrization tests #2423

merged 1 commit into from
Jun 28, 2022

Conversation

hakonsbm
Copy link
Contributor

Due to tiny differences in values calculated in the NEST kernel, some tests in the CI fail. assertEqual is therefore changed to assertAlmostEqual in relevant tests.

@hakonsbm hakonsbm added S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 24, 2022
@hakonsbm hakonsbm added this to In progress in PyNEST via automation Jun 24, 2022
PyNEST automation moved this from In progress to Review Jun 26, 2022
@hakonsbm hakonsbm linked an issue Jun 28, 2022 that may be closed by this pull request
Numerical instability found in test suite #2425
Closed
@heplesser heplesser merged commit 61f08e0 into nest:master Jun 28, 2022
PyNEST automation moved this from Review to Done Jun 28, 2022
@hakonsbm hakonsbm deleted the assertalmostequal_in_test_nodeparametrization branch June 28, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@nicolossus nicolossus nicolossus approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numerical instability found in test suite
3 participants
@hakonsbm @heplesser @nicolossus