Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer changes from release branch back to master #2436

Merged
merged 6 commits into from
Jul 27, 2022
Merged

Transfer changes from release branch back to master #2436

merged 6 commits into from
Jul 27, 2022

Conversation

gtrensch
Copy link
Contributor

Cherry-picked changes from pull request #2433.

@gtrensch gtrensch requested a review from terhorstd July 25, 2022 13:54
@terhorstd terhorstd added this to In progress in Documentation via automation Jul 25, 2022
@gtrensch gtrensch added T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next labels Jul 25, 2022
terhorstd
terhorstd approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and was already reviewed in #2433. 👍

Documentation automation moved this from In progress to Review Jul 25, 2022
@terhorstd terhorstd merged commit 3d4f750 into nest:master Jul 27, 2022
Documentation automation moved this from Review to Done Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gtrensch @terhorstd @jessica-mitchell