Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add += operator for compartment model #2444

Merged
merged 17 commits into from
Nov 28, 2022
Merged

Add += operator for compartment model #2444

merged 17 commits into from
Nov 28, 2022

Conversation

hakonsbm
Copy link
Contributor

@hakonsbm hakonsbm commented Aug 4, 2022

An addition assignment operator is added for compartments, and the cm_default model is updated. Fixes #2309.

@hakonsbm hakonsbm added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Aug 4, 2022
@hakonsbm hakonsbm added this to In progress in PyNEST via automation Aug 4, 2022
WillemWybo
WillemWybo reviewed Aug 30, 2022
View reviewed changes
models/cm_default.cpp Outdated Show resolved Hide resolved
@WillemWybo
Copy link
Contributor

Thank you very much for this. I only have one comment pertaining to the set_status call. The rest looks good to me.

@hakonsbm
Copy link
Contributor Author

@WillemWybo I've updated the PR with the equivalent functions for receptors now, please have another look.

@WillemWybo
Copy link
Contributor

WillemWybo commented Oct 20, 2022 •
edited

Everything looks good to me, nice work! @hakonsbm

@heplesser
Copy link
Contributor

heplesser commented Oct 20, 2022 •
edited

Everything looks good to me, nice work! @hakonsbm

@WillemWybo Could you then formally approve the PR and resolve all open conversations you started? Otherwise, we cannot merge.

@WillemWybo
Copy link
Contributor

Approved! @heplesser

@heplesser
Copy link
Contributor

@pnbabu Ping!

pnbabu
pnbabu approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@heplesser
Copy link
Contributor

@hakonsbm I have re-started the FULL_MACOS job, the failure seems spurious, at least nothing in the latest commit that would explain it.

@heplesser heplesser merged commit 0c16c31 into nest:master Nov 28, 2022
PyNEST automation moved this from In progress to Done Nov 28, 2022
@hakonsbm hakonsbm deleted the cm_addition_assignment_operator branch November 28, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillemWybo WillemWybo WillemWybo approved these changes

@pnbabu pnbabu pnbabu approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
PyNEST
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

+= operator for parameter collections
4 participants
@hakonsbm @WillemWybo @heplesser @pnbabu