Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some dimensions in developer documentation adex neurons #2447

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix some dimensions in developer documentation adex neurons #2447

merged 1 commit into from
Aug 17, 2022

Conversation

jarsi
Copy link
Contributor

@jarsi jarsi commented Aug 15, 2022

I wanted to try out the adaptive exponential integrate-and-fire neuron models and realized that some of the comments about the dimensions of the variables in the text seem to be incorrect: The slope factor Delta_T is mV, not ms, see the original publication. This PR corrects the dimensions.

@heplesser heplesser self-requested a review August 17, 2022 20:14
@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 17, 2022
@heplesser heplesser added this to To do in Models via automation Aug 17, 2022
heplesser
heplesser approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this. Fortunately, it has been correct in the user documentation already. Since it is a minimal documentation fix, I merge based on single review.

@heplesser heplesser changed the title Fix some dimensions in adex neurons Fix some dimensions in developer documentation adex neurons Aug 17, 2022
@heplesser heplesser merged commit 8ccdebe into nest:master Aug 17, 2022
@clinssen clinssen moved this from To do to Done in Models Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Models
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jarsi @heplesser