Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image scaling in docs #2448

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Fix image scaling in docs #2448

merged 2 commits into from
Aug 17, 2022

Conversation

jessica-mitchell
Copy link
Contributor

This PR fixes scaling issues of some images in the documentation.
Only images that used in the titles of grid cards (i.e. icons for individual topics) are limited in pixel size.

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 15, 2022
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Aug 15, 2022
@jessica-mitchell jessica-mitchell added the need reviewer Ready to be reviewed but no reviewer assigned label Aug 15, 2022
heplesser
heplesser approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since it is a minimal documentation change, I merge based on single review.

@heplesser heplesser merged commit f7cd29c into nest:master Aug 17, 2022
Documentation automation moved this from In progress to Done Aug 17, 2022
@jessica-mitchell jessica-mitchell deleted the fix-images branch April 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) need reviewer Ready to be reviewed but no reviewer assigned S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessica-mitchell @heplesser