Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in clang-format version handling #2449

Merged
merged 9 commits into from
Aug 17, 2022
Merged

Fix errors in clang-format version handling #2449

merged 9 commits into from
Aug 17, 2022

Conversation

heplesser
Copy link
Contributor

@heplesser heplesser commented Aug 15, 2022 •
edited

This PR fixes errors in handling clang-format versions.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 15, 2022
@heplesser heplesser added this to To do in Installation via automation Aug 15, 2022
@heplesser heplesser changed the title Parse multi-digit version numbers of clang-format correctly Fix errors in clang-format version handling Aug 16, 2022
heplesser added a commit to heplesser/nest-simulator that referenced this pull request Aug 16, 2022
@heplesser
Manually add clang-format fix from nest#2449.
4ffd504
gtrensch
gtrensch approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍.

@hakonsbm hakonsbm merged commit 39eb96c into nest:master Aug 17, 2022
Installation automation moved this from To do to Done Aug 17, 2022
@heplesser heplesser deleted the fix-code-style-check-problems branch October 4, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakonsbm hakonsbm hakonsbm approved these changes

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Installation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @hakonsbm @gtrensch