Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on discretization of uniformly distributed delays #2452

Merged
merged 11 commits into from
Aug 23, 2022
Merged

Add documentation on discretization of uniformly distributed delays #2452

merged 11 commits into from
Aug 23, 2022

Conversation

heplesser
Copy link
Contributor

Explain in more detail how delays are discretized when drawn from a uniform distribution.

This fixes #833.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 19, 2022
@heplesser heplesser added this to In progress in Documentation via automation Aug 19, 2022
hakonsbm
hakonsbm suggested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have just a couple minor suggestions.

doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
Documentation automation moved this from In progress to Review Aug 22, 2022
heplesser and others added 3 commits August 22, 2022 09:37
@heplesser @hakonsbm
Fix typo.
ee2d2da 
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
@heplesser @hakonsbm
Python code formatting
3f250e1 
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
@heplesser
Fix whitespace around operators.
cf82210
jessica-mitchell
jessica-mitchell requested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions. Thanks @heplesser

doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
doc/htmldoc/nest_behavior/random_numbers.rst Outdated Show resolved Hide resolved
heplesser and others added 5 commits August 22, 2022 12:43
@heplesser @jessica-mitchell
Expand abbreviation.
471257e 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@heplesser @jessica-mitchell
Improve punctuation.
68f4c3d 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@heplesser @jessica-mitchell
Clarify wording.
6ff998c 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@heplesser @jessica-mitchell
Clarify wording.
7c31b4f 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@heplesser @jessica-mitchell
Fix punctuation.
8847faa 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@heplesser
Copy link
Contributor Author

@jessica-mitchell @hakonsbm Thank you for your suggestions! All should be fixed now.

jessica-mitchell
jessica-mitchell approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@heplesser @jessica-mitchell
Improve punctuation.
2ad3a18 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
hakonsbm
hakonsbm approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@hakonsbm hakonsbm merged commit 7086c3c into nest:master Aug 23, 2022
Documentation automation moved this from Review to Done Aug 23, 2022
@heplesser heplesser deleted the fix-833-delay-rounding branch October 4, 2022 21:11
@gtrensch gtrensch mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@hakonsbm hakonsbm hakonsbm approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uniform distribution of delays isn't uniform
3 participants
@heplesser @jessica-mitchell @hakonsbm