Install assimulo from conda-forge #2455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aeif_models_implementation
requires theassimulo
package to compute reference solutions. The notebook previously suggested installation from PyPi, but assimulo is outdated there (3.0 from 2018) and does not build any longer. A current version is available on conda-forge. This PR therefore addsassimulo
toenvironments.yml
and updates the requirements information in the notebook.@jougs @terhorstd Since this introduces yet another dependency for a corner case, I'd like your comments.
Fixes #2454.