Remove padding of extent if not specified when creating free positions #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Center is rounded to the first decimal. Single-node layers require extent to be explicitly specified.
hakonsbm
added
T: Bug
heplesser
added
I: Behavior changes
heplesser
requested changes
Aug 29, 2022
There was a problem hiding this comment.
@hakonsbm Thanks for fixing this! I have added some comments, mostly minor points. Since this bug fix will change behavior of existing scripts, please add some explicit information about this in the release notes, although I am right now not certain if for v3.4 or v3.5.
Removed irrelevant test of center value, changed to `assertAlmostEqual`, and added test of 3 dimension case.
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Because assertAlmostEqual() doesn't work with tuples of floats.
heplesser
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2359 by removing padding of extent if no extent is specified when creating the positions. Extent is instead rounded up and adjusted to a rounded centre. If only a single node is created, extent must be specified.