Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to What's new in 3.4 about new functions #2462

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

jessica-mitchell
Copy link
Contributor

This PR adds text to the What's new section for 3.4 regarding the PR #2394.
This is a nice feature that should be highlighted, and I assume (@gtrensch @terhorstd) release for 3.4 has not been fixed yet and is still taking new PRs from master.

@jessica-mitchell jessica-mitchell added S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 7, 2022
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Sep 7, 2022
@jessica-mitchell jessica-mitchell added this to the NEST 3.4 milestone Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Nov 7, 2022
@heplesser heplesser requested review from heplesser and removed request for ackurth November 28, 2022 09:42
@jessica-mitchell jessica-mitchell moved this from In progress to Review in Documentation Nov 30, 2022
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessica-mitchell I have revised the text a bit to address the user more directly.

doc/htmldoc/whats_new/v3.4/index.rst Outdated Show resolved Hide resolved
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
@heplesser
Copy link
Contributor

Simple documentation change, therefore merging based on single review and without waiting for tests to complete.

@heplesser heplesser merged commit f929f1b into nest:master Nov 30, 2022
Documentation automation moved this from Review to Done Nov 30, 2022
@jessica-mitchell jessica-mitchell deleted the update-whatsnew3.4 branch April 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants