Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct library information provided to extension modules #2468

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Correct library information provided to extension modules #2468

merged 2 commits into from
Sep 21, 2022

Conversation

heplesser
Copy link
Contributor

Until now, the library information provided by nest-config --libs for extension module building include -lnest, i.e., libnest. This library only includes nest_startup.{h,cpp} and is only needed for the NEST executable or main PyNEST module. It can lead to loading problems when included with extension modules.

This PR ensures that -lnest is not returned by nest-config --libs.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 14, 2022
@heplesser heplesser added this to To do in Installation via automation Sep 14, 2022
clinssen
clinssen reviewed Sep 14, 2022
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@clinssen
Copy link
Contributor

NESTML modules seem to build just fine against this branch. Approving!

@heplesser @clinssen
Fix typo.
81c552f 
Co-authored-by: clinssen <c.linssen@fz-juelich.de>
jougs
jougs approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your investigation and the fix.

@jougs jougs merged commit 0ef17ef into nest:master Sep 21, 2022
Installation automation moved this from To do to Done Sep 21, 2022
@heplesser heplesser deleted the fix-nest-config branch October 4, 2022 21:04
@heplesser heplesser mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Installation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @clinssen @jougs