Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for CreateParameter #2475

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Update documentation for CreateParameter #2475

merged 2 commits into from
Oct 18, 2022

Conversation

hakonsbm
Copy link
Contributor

Fixes #2291.

@hakonsbm hakonsbm added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 21, 2022
@hakonsbm hakonsbm added this to In progress in Documentation via automation Sep 21, 2022
jessica-mitchell
jessica-mitchell approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hakonsbm I have one minor suggestion, but I will go ahead and approve.

pynest/nest/lib/hl_api_types.py Outdated Show resolved Hide resolved
@hakonsbm @jessica-mitchell
Updated documentation text
a1f7833 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@jessica-mitchell jessica-mitchell merged commit e02ada0 into nest:master Oct 18, 2022
Documentation automation moved this from In progress to Done Oct 18, 2022
@hakonsbm hakonsbm deleted the parameter_doc branch October 18, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Troubles with nest.CreateParameter(parametertype, specs) function
3 participants
@hakonsbm @heplesser @jessica-mitchell