Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spike-transmission test to multithreading test #2476

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add spike-transmission test to multithreading test #2476

merged 1 commit into from
Sep 22, 2022

Conversation

heplesser
Copy link
Contributor

test_multithreading.sli until now only tests that thread numbers are set correctly and that nodes are correctly assigned to VPs. This test also checks that spikes are correctly transmitted between nodes on different threads.

@heplesser heplesser added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 21, 2022
@heplesser heplesser added this to PRs in progress in Kernel via automation Sep 21, 2022
jougs
jougs approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I don't think we need a second review here and will merge immediately.

@jougs jougs merged commit f9dd368 into nest:master Sep 22, 2022
Kernel automation moved this from PRs in progress to Done (PRs and issues) Sep 22, 2022
@heplesser heplesser deleted the extend-test-multithreading branch October 4, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@med-ayssar med-ayssar Awaiting requested review from med-ayssar

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heplesser @jougs