Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the PR base as reference SHA when getting changed files #2478

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Use the PR base as reference SHA when getting changed files #2478

merged 2 commits into from
Nov 28, 2022

Conversation

hakonsbm
Copy link
Contributor

The PR base is the commit in master that the branch is built on. Using that as the reference for changed files ensures that the correct files are detected when getting changed files for the static code analysis. Fixes #2471.

@hakonsbm hakonsbm added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 22, 2022
@hakonsbm hakonsbm added this to To do in Build system and CI via automation Sep 22, 2022
@hakonsbm hakonsbm mentioned this pull request Sep 30, 2022
Merged
@jougs jougs requested review from jougs and terhorstd October 24, 2022 11:41
jougs
jougs approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wholeheartedly approve :-)

@heplesser
Copy link
Contributor

@terhorstd approved verbally.

@heplesser heplesser merged commit e49be2a into nest:master Nov 28, 2022
Build system and CI automation moved this from To do to Done Nov 28, 2022
@hakonsbm hakonsbm deleted the gha_changed_files branch November 28, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@terhorstd terhorstd Awaiting requested review from terhorstd

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Build system and CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All files in PRs are not always checked by static code analysis
3 participants
@hakonsbm @heplesser @jougs