Improve clarity of -Dwith-python error message
#2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy forms of `Dwith-python=2/3` still circulate. If a user now specifies `-Dwith-python=3` they are met with the message `Invalid option: -Dwith-python=3`. This message implies that the option `-Dwith-python` is invalid and unrecognized by CMake. I changed the error message to clarify that the given value is invalid, and `ON` or `OFF` should be given instead.
hakonsbm
added
S: Normal
jougs
approved these changes
Oct 24, 2022
jougs
changed the title
Dwith-python error-Dwith-python error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy forms of
Dwith-python=2/3still circulate. If a user now specifies-Dwith-python=3they are met with the messageInvalid option: -Dwith-python=3. This message implies that the option-Dwith-pythonis invalid and unrecognized by CMake. I changed the error message to clarify that the option is valid, but the given value is invalid, andONorOFFshould be given instead.