Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure do_tests.sh completes even when tests fail #2491

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Ensure do_tests.sh completes even when tests fail #2491

merged 1 commit into from
Oct 11, 2022

Conversation

heplesser
Copy link
Contributor

@heplesser heplesser commented Oct 6, 2022 •
edited

This PR changes do_tests.sh to turn off "exit on error" for the parts that execute Python and C++ tests so that failures can be properly collected and reported by our log analysis. For SLI-based tests, this is handled in run_test.sh.

This fixes #2487.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 6, 2022
@heplesser heplesser added this to To do in Build system and CI via automation Oct 6, 2022
jougs
jougs approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks totally good to me. This is probably the behavior that we initially should have had all along.

@gtrensch gtrensch self-requested a review October 10, 2022 10:24
gtrensch
gtrensch approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@heplesser heplesser removed the request for review from terhorstd October 11, 2022 20:02
@heplesser heplesser merged commit 4e23af2 into nest:master Oct 11, 2022
Build system and CI automation moved this from To do to Done Oct 11, 2022
@heplesser heplesser deleted the fix-2487-do-tests branch October 17, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Build system and CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do_tests.sh terminates early if Python tests fail
3 participants
@heplesser @jougs @gtrensch