Modernize the codebase - check for nullptr #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
S: Normal
jougs
reviewed
Oct 10, 2022
jougs
reviewed
Oct 10, 2022
jougs
reviewed
Oct 10, 2022
|
Not sure why, but after the latest commit, I now double-checked both |
heplesser
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
@JanVogelsang Looks good, thank you! In the next PR (replacing &&, ||, and ! with and, or and not), it would be good to also remove superfluous parentheses in boolean expression, e.g. of to form (n1) and (n2).
|
And merging ... |
I could only find very few occurrences (~25) of redundant parentheses, but I think I got them all. PR is incoming as soon as all tests pass. |
jougs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #2493.
In the C++ standard it is defined that
if ( ptr != nullptr )gives the same result asif ( ptr )asptris converted to aboolin the latter case, which per standard evaluates totrueonly ifptr != nullptr.We can therefore convert all occurrences of
if ( ptr != nullptr )toif ( ptr )and
if ( ptr == nullptr )toif ( not ptr )which makes it quite clear in which cases a pointer is expected to be valid and when not.