Modernize the codebase - remove leftover NULLs #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanVogelsang I restarted one failed test, it seemed to be a technical issue on the runner. I would much prefer to put this PR in draft mode until #2498 is merge and base this PR on code with #2498 integrated. Otherwise it becomes more difficult to review and there is a small risk that merging this one would reintroduce && and II if diff should get confused. |
jougs
requested review from
heplesser and
jougs
and removed request for
heplesser
jougs
added
S: Normal
jougs
changed the title
heplesser
requested changes
Oct 20, 2022
jougs
reviewed
Nov 10, 2022
There was a problem hiding this comment.
Thanks! Other than my few comments, I'm fine with this.
One general question now that I come to think of it: Did any of your recent cleanup PRs touch code in the thirdparty directory? Our usual policy is to leave those as is in order to match the upstream code as good as possible. They are also excluded from our static code checks in the CI.
heplesser
requested changes
Nov 10, 2022
heplesser
reviewed
Nov 10, 2022
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
heplesser
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some occurrences of
NULLkeywords that were not picked up byclang-tidyand are now added in this PR.