Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Parameter objects for indegree and outdegree in syn_specs #2501

Merged
merged 6 commits into from
Oct 31, 2022

Conversation

hakonsbm
Copy link
Contributor

Attempts to fix #1615 by implementing the possibility to pass a Parameter object as indegree in fixed_indegree or as outdegree in fixed_outdegree.

Example:

conn_spec = {'rule': 'fixed_indegree', 
             'indegree': nest.random.normal(mean=20.0, std=2.0),
             'p': nest.spatial_distributions.gaussian(nest.spatial.distance, std=0.5),
             'allow_multapses': True}

@hakonsbm hakonsbm added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 13, 2022
@hakonsbm hakonsbm requested a review from jhnnsnk October 13, 2022 13:13
@hakonsbm hakonsbm added this to PRs in progress in Kernel via automation Oct 13, 2022
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think that one now can pass a Parameter object as indegree/outdegree should be documented. I guess doc/htmldoc/synapses/connection_management.rst would be a good place for the documentation, but there might be another more suitable location.

Kernel automation moved this from PRs in progress to PRs pending approval Oct 28, 2022
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only have a minor grammatical suggestion, otherwise I approve once all tests pass

doc/htmldoc/networks/spatially_structured_networks.rst Outdated Show resolved Hide resolved
hakonsbm and others added 2 commits October 28, 2022 14:07
Co-authored-by: Nicolai Haug <39106781+nicolossus@users.noreply.github.com>
Copy link
Contributor

@jhnnsnk jhnnsnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you very much for this useful addition! 👍

@heplesser heplesser changed the title Possibility to use Parameter object for indegree and outdegree Add support for Parameter objects for indegree and outdegree in syn_specs Oct 31, 2022
@heplesser heplesser merged commit d7ef15b into nest:master Oct 31, 2022
Kernel automation moved this from PRs pending approval to Done (PRs and issues) Oct 31, 2022
@hakonsbm hakonsbm deleted the indegree_outdegree_parameter branch October 31, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Kernel
  
Done
Development

Successfully merging this pull request may close these issues.

Distributed indegree
4 participants