Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std::vector in SecondaryEvent with std::set #2507

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Replace std::vector in SecondaryEvent with std::set #2507

merged 3 commits into from
Oct 24, 2022

Conversation

med-ayssar
Copy link
Contributor

@med-ayssar med-ayssar commented Oct 19, 2022 •
edited

The SecondaryEvent class in secondary_event.h uses the std::vector to implement the same logic as the std::set. Therefore, It is more appropriate to use directly the set implementation.

@med-ayssar med-ayssar changed the title Replace std::Vector with std::Set in Replace std::Vector with std::Set in SecondaryEvent Oct 19, 2022
@med-ayssar med-ayssar mentioned this pull request Oct 19, 2022
Merged
@med-ayssar med-ayssar marked this pull request as ready for review October 19, 2022 15:10
@med-ayssar
Copy link
Contributor Author

@jougs, could you take a look.

@jougs jougs requested review from jougs and heplesser October 19, 2022 16:39
jougs
jougs requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good in principle, but I would go a bit further. See my comments.

nestkernel/secondary_event.h Show resolved Hide resolved
nestkernel/secondary_event.h Outdated Show resolved Hide resolved
nestkernel/secondary_event.h Outdated Show resolved Hide resolved
nestkernel/secondary_event.h Outdated Show resolved Hide resolved
nestkernel/secondary_event.h Outdated Show resolved Hide resolved
nestkernel/target_table_devices_impl.h Outdated Show resolved Hide resolved
@heplesser heplesser changed the title Replace std::Vector with std::Set in SecondaryEvent Replace std::vector with std::set in SecondaryEvent Oct 20, 2022
heplesser
heplesser approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@med-ayssar Thanks! I agree with all suggestions by @jougs. To simplify the workflow, I approve now, assuming that @jougs will only approve once you have followed up on his suggestions.

@jougs jougs merged commit 723d328 into nest:master Oct 24, 2022
@jougs jougs changed the title Replace std::vector with std::set in SecondaryEvent Replace std::vector in SecondaryEvent with std::set Oct 24, 2022
@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Oct 24, 2022
@jougs jougs added this to PRs in progress in Kernel via automation Oct 24, 2022
@terhorstd terhorstd moved this from PRs in progress to Done (PRs and issues) in Kernel Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@med-ayssar @heplesser @jougs