Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update port in NESTServerClient #2510

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Update port in NESTServerClient #2510

merged 1 commit into from
Oct 24, 2022

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Oct 24, 2022

This PR updates the port in NESTServerClient.

For more details, see #2505 .

@jougs jougs self-requested a review October 24, 2022 11:38
@jougs jougs added S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 24, 2022
jougs
jougs approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging without second reviewer due to this being a trivial change

@jougs
Copy link
Contributor

jougs commented Oct 24, 2022

Also ignoring the MacOS failure, as that is unrelated to this change.

@jougs jougs merged commit 26a21ce into nest:master Oct 24, 2022
@babsey babsey deleted the nestServerClient-port branch October 24, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@babsey @jougs