Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests of MUSIC models #2514

Merged
merged 4 commits into from
Oct 27, 2022
Merged

Add missing tests of MUSIC models #2514

merged 4 commits into from
Oct 27, 2022

Conversation

hakonsbm
Copy link
Contributor

Adds tests for music_rate_in_proxy, music_rate_out_proxy, and music_message_in_proxy.

Should fix #1459, but I'm not sure if we need some additional tests with more processes, as the tests test_cont_proxy.music and issue_1974.sli already use multiple processes. Any comment on this, @heplesser?

@hakonsbm hakonsbm added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 25, 2022
@hakonsbm hakonsbm added this to In progress in Automated testing via automation Oct 25, 2022
Automated testing automation moved this from In progress to Needs review Oct 25, 2022
heplesser
heplesser requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one little point and I think these tests suffice.

testsuite/do_tests.sh Show resolved Hide resolved
@hakonsbm hakonsbm requested a review from jougs October 26, 2022 09:58
jougs
jougs approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing this.

@jougs jougs merged commit 8c386ce into nest:master Oct 27, 2022
Automated testing automation moved this from Needs review to Done Oct 27, 2022
@hakonsbm hakonsbm deleted the music_tests branch November 25, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
No open projects
Automated testing
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing tests of MUSIC models
3 participants
@hakonsbm @heplesser @jougs