-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing colon and correct comment #2525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JanVogelsang I can only comment on the change to the iaf_cond_alpha.h
, and that looks good.
Someone who knows the C++ should check the other line @jougs @heplesser ?
@JanVogelsang Thank you for this PR. I will merge it now but would like to ask you to further improve the doxygen comments on data members in nest-simulator/nestkernel/connection.h Lines 300 to 310 in b692c32
The comment on nest-simulator/nestkernel/nest_types.h Line 84 in b692c32
and nest-simulator/nestkernel/nest_types.h Line 88 in b692c32
|
Fair point, I will look into this. Didn't know the bitmasks were different for HPC and non-HPC, is that noted in the user documentation somewhere as well? |
There was a missing colon in models/iaf_cond_alpha_mc.h which caused a reference to not be displayed correctly.
A comment in nestkernel/connection.h stated incorrect bit-sizes, probably an artifact of older versions.