Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node name to PortAlreadyPublished error in music_cont_in_proxy #2534

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Add node name to PortAlreadyPublished error in music_cont_in_proxy #2534

merged 3 commits into from
Nov 30, 2022

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Nov 25, 2022

Fixes #1390

@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Nov 25, 2022
@jougs jougs self-assigned this Nov 25, 2022
@jougs jougs added this to To do in Models via automation Nov 25, 2022
heplesser
heplesser requested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jougs Thanks! I added suggestions to use const& instead of pointer.

models/music_cont_in_proxy.cpp Show resolved Hide resolved
models/music_cont_in_proxy.cpp Outdated Show resolved Hide resolved
models/music_cont_in_proxy.cpp Outdated Show resolved Hide resolved
models/music_cont_in_proxy.h Show resolved Hide resolved
@jougs
Copy link
Contributor Author

jougs commented Nov 29, 2022

I went for Node* to be consistent with what we have in virtually all other models (e.g. here, here, here, ...) and while I agree in principle, I would not want to address this here and only for this one model.

@heplesser
Copy link
Contributor

OK! And now the FULL run fails again ...

@jougs jougs merged commit b9cda7c into nest:master Nov 30, 2022
@heplesser heplesser moved this from To do to Done in Models Dec 1, 2022
@jougs jougs changed the title Fix open TODO in music_cont_in_proxy Add node name to PortAlreadyPublished error in music_cont_in_proxy Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@med-ayssar med-ayssar Awaiting requested review from med-ayssar

Assignees

@jougs jougs

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Models
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open TODO in music_cont_in_proxy.cpp
3 participants
@jougs @heplesser @med-ayssar