Revising comments on Event class #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
S: Normal
jessica-mitchell
requested changes
Nov 28, 2022
There was a problem hiding this comment.
@heplesser thanks for looking at this ancient issue; I just have some minor fixes from my side.
|
Looks good to me. |
med-ayssar
approved these changes
Nov 29, 2022
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
|
@jessica-mitchell Thanks for your suggestions, I have accepted them all. |
jessica-mitchell
approved these changes
Nov 29, 2022
|
Since the test failure is due to causes entirely unrelated to this PR, I merge in spite of one failing test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides updated developer documentation for the
Eventclass. It thus fixes #129. At a later stage, theEventclass hierarchy should be reviewed fully.