Improve documentation on some HH models #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
S: Normal
jessica-mitchell
requested changes
Nov 29, 2022
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
|
@jessica-mitchell Thank you for your suggestions, all accepted. |
jessica-mitchell
approved these changes
Nov 29, 2022
clinssen
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #329 by making the documentation of the spike-emission mechanism of
hh_cond_exp_traubeven more visible and also fixes documentation forhh_cond_beta_gap_traub. Further work on better spike detection methods for these models seems not warranted at this time, also to not break the behaviour of existing code.