Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved comments on weight positivity for conductance-based multisynapse models #2540

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Improved comments on weight positivity for conductance-based multisynapse models #2540

merged 3 commits into from
Dec 1, 2022

Conversation

heplesser
Copy link
Contributor

The title says it all. This fixed #2146.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Nov 28, 2022
@heplesser heplesser added this to In progress in Documentation via automation Nov 28, 2022
jessica-mitchell
jessica-mitchell approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heplesser I approve with only one small comment, thanks

models/gif_cond_exp_multisynapse.h Outdated Show resolved Hide resolved
@heplesser @jessica-mitchell
Improve language based on suggestion from code review.
6e67fe8 
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@jessica-mitchell jessica-mitchell moved this from In progress to Review in Documentation Nov 30, 2022
clinssen
clinssen approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion. Cheers!

models/gif_cond_exp_multisynapse.cpp Outdated Show resolved Hide resolved
@heplesser @clinssen
Update models/gif_cond_exp_multisynapse.cpp
e2b9b12 
Co-authored-by: clinssen <c.linssen@fz-juelich.de>
@heplesser heplesser merged commit e08eb68 into nest:master Dec 1, 2022
Documentation automation moved this from Review to Done Dec 1, 2022
@heplesser heplesser deleted the fix-2146-cond-doc branch December 19, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency between _cond_ and _cond_multisynapse implementations
3 participants
@heplesser @jessica-mitchell @clinssen