Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct documentation for aeif_psc models #2550

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Correct documentation for aeif_psc models #2550

merged 2 commits into from
Dec 5, 2022

Conversation

heplesser
Copy link
Contributor

This corrects documentation for current-based AEIF neurons anf fixes #2486.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Nov 30, 2022
@heplesser heplesser added this to In progress in Documentation via automation Nov 30, 2022
jessica-mitchell
jessica-mitchell approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heplesser lgtm!

@jessica-mitchell jessica-mitchell moved this from In progress to Review in Documentation Nov 30, 2022
zbarni
zbarni reviewed Dec 1, 2022
View reviewed changes
models/aeif_psc_exp.h Outdated Show resolved Hide resolved
zbarni
zbarni reviewed Dec 1, 2022
View reviewed changes
Copy link

@zbarni zbarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment, it looks good to me as well.

@heplesser heplesser requested a review from zbarni December 1, 2022 21:14
@heplesser
Copy link
Contributor Author

@zbarni Could you re-review, approve if you are happy and resolve the conversation if it does not get resolved automatically by approving?

zbarni
zbarni approved these changes Dec 3, 2022
View reviewed changes
Copy link

@zbarni zbarni left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@heplesser heplesser merged commit 26026c2 into nest:master Dec 5, 2022
Documentation automation moved this from Review to Done Dec 5, 2022
@heplesser heplesser deleted the fix-2486-aeif-doc branch December 19, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbarni zbarni zbarni approved these changes

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdEx equations incorrect for current-based models
3 participants
@heplesser @jessica-mitchell @zbarni