Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MUSIC status printout up in the summary #2575

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Move MUSIC status printout up in the summary #2575

merged 3 commits into from
Jan 16, 2023

Conversation

med-ayssar
Copy link
Contributor

Changing the order of the version check of the MUSIC executable seems to work without breaking the build phase of the full-nest-build stage.

@med-ayssar med-ayssar force-pushed the test-breaking-pipeline-at-full-build branch from b7d1de1 to bff22d2 Compare January 4, 2023 13:45
nicolossus added a commit to nicolossus/nest-simulator that referenced this pull request Jan 5, 2023
@nicolossus
Try possible CI testsuite fix from PR nest#2575
e2a7d08
@jessica-mitchell jessica-mitchell added this to To do in Build system and CI via automation Jan 10, 2023
nicolossus added a commit to nicolossus/nest-simulator that referenced this pull request Jan 10, 2023
@nicolossus
Apply CI testsuite fix from nest#2575
c031c04
@terhorstd terhorstd moved this from To do to In progress in Build system and CI Jan 16, 2023
@terhorstd terhorstd added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 16, 2023
@terhorstd terhorstd moved this from In progress to Review in Build system and CI Jan 16, 2023
jougs
jougs approved these changes Jan 16, 2023
View reviewed changes
testsuite/do_tests.sh Outdated Show resolved Hide resolved
testsuite/do_tests.sh Outdated Show resolved Hide resolved
@heplesser heplesser requested review from jougs and removed request for lekshmideepu January 16, 2023 11:20
@jougs jougs changed the title Move MUSIC version check to the top Move MUSIC status printout up in the summary Jan 16, 2023
@jougs jougs merged commit 3aed9b1 into nest:master Jan 16, 2023
Build system and CI automation moved this from Review to Done Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jougs jougs Awaiting requested review from jougs

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Build system and CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@med-ayssar @heplesser @jougs @terhorstd