Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace while-loop with C++ find_if function #2578

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Replace while-loop with C++ find_if function #2578

merged 4 commits into from
Jan 17, 2023

Conversation

med-ayssar
Copy link
Contributor

No description provided.

jougs
jougs reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor cleanup.

nestkernel/universal_data_logger.h Outdated Show resolved Hide resolved
nestkernel/universal_data_logger.h Outdated Show resolved Hide resolved
@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Jan 12, 2023
@jougs jougs added this to PRs in progress in Kernel via automation Jan 12, 2023
@jougs jougs requested a review from hakonsbm January 12, 2023 12:28
jougs
jougs approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@terhorstd terhorstd moved this from PRs in progress to PRs pending approval in Kernel Jan 16, 2023
hakonsbm
hakonsbm suggested changes Jan 17, 2023
View reviewed changes
nestkernel/universal_data_logger.h Outdated Show resolved Hide resolved
hakonsbm
hakonsbm approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hakonsbm hakonsbm merged commit 0d320b3 into nest:master Jan 17, 2023
Kernel automation moved this from PRs pending approval to Done (PRs and issues) Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@hakonsbm hakonsbm hakonsbm approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@med-ayssar @jougs @hakonsbm