Change order of pre_run hook in SimulationManager
#2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jougs
added
I: Internal API
|
I have no objection, thanks! |
|
@med-ayssar , could you give approval in the review, so that we can more easily spot that this is ready to merge? |
med-ayssar
approved these changes
Jan 17, 2023
jougs
changed the title
SimulationManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By rearranging the pre_run hook call it allows callees to access information about the simulation time in their pre_run implementation.
Otherwise callees are not able to reliable get these information before the run starts as the simulation time is only known when calling the run() method and the sim time is currently set after the pre_run hook.
Additionally, the pre_run hook is only called if a run will take place at all.
As far as I see the reordering should be safe as there are no dependencies between the reordered lines.