Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mocker regex to avoid failures when building documentation #2589

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix mocker regex to avoid failures when building documentation #2589

merged 1 commit into from
Jan 17, 2023

Conversation

hakonsbm
Copy link
Contributor

Replaced \b with \s in the regex to avoid removing wrong ints when mocking pynestkernel. Fixes #2576.

@hakonsbm hakonsbm added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 17, 2023
@hakonsbm hakonsbm added this to In progress in Documentation via automation Jan 17, 2023
@hakonsbm hakonsbm mentioned this pull request Jan 17, 2023
Closed
jessica-mitchell
jessica-mitchell approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the local build and RtD, both build successfully! thanks @hakonsbm

@jougs jougs self-requested a review January 17, 2023 10:36
jougs
jougs approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@jougs jougs changed the title Fix mocker regex Fix mocker regex to avoid failures when building documentation Jan 17, 2023
@jougs jougs merged commit 87d591c into nest:master Jan 17, 2023
Documentation automation moved this from In progress to Done Jan 17, 2023
@hakonsbm hakonsbm deleted the fix_mocker_regex branch January 17, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read the Docs build fails on master
3 participants
@hakonsbm @jougs @jessica-mitchell