Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badges of the different NEST packages #2599

Merged
merged 11 commits into from
Mar 7, 2023

Conversation

steffengraber
Copy link
Contributor

This PR prepares the badges for the new version 3.4. This concerns the docker image and the virtual application image. For both, the version has to be changed manually.
All other badges should update themselves automatically.

@terhorstd
Copy link
Contributor

Thanks for helping here, @steffengraber ! One question: would you also create a 3.4 vm already that we could link, or would we do that in another way somehow?

@steffengraber
Copy link
Contributor Author

Thanks for helping here, @steffengraber ! One question: would you also create a 3.4 vm already that we could link, or would we do that in another way somehow?

I have created a 3.4 vm. It is linked as nest-latest.ova in the documentation.

Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me!

@jessica-mitchell jessica-mitchell changed the title Fix badges to the differnt NEST packages Fix badges of the different NEST packages Feb 6, 2023
@jessica-mitchell jessica-mitchell added T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 6, 2023
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Feb 6, 2023
@jessica-mitchell jessica-mitchell added this to To do in Installation via automation Feb 6, 2023
README.md Outdated Show resolved Hide resolved
Documentation automation moved this from In progress to Review Feb 10, 2023
Installation automation moved this from To do to Review Feb 10, 2023
@terhorstd terhorstd moved this from Review to In progress in Installation Feb 10, 2023
@terhorstd terhorstd moved this from Review to In progress in Documentation Feb 10, 2023
@steffengraber
Copy link
Contributor Author

As previously discussed, the NEST repository on dockerhub is now automatically kept up to date again. The badge automatically links to the latest stable version.

Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a pressing reason why we should not link to dockerhub anymore, I'd put the link back in.
The other changes look fine to me.

README.md Outdated Show resolved Hide resolved
Documentation automation moved this from In progress to Review Feb 24, 2023
Installation automation moved this from In progress to Review Feb 24, 2023
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! LGTM! 👍

@terhorstd terhorstd added the S: Normal Handle this with default priority label Mar 7, 2023
@terhorstd terhorstd merged commit 4192435 into nest:master Mar 7, 2023
Documentation automation moved this from Review to Done Mar 7, 2023
Installation automation moved this from Review to Done Mar 7, 2023
@steffengraber steffengraber deleted the fix-badges branch September 6, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Installation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants