-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix badges of the different NEST packages #2599
Conversation
Thanks for helping here, @steffengraber ! One question: would you also create a 3.4 vm already that we could link, or would we do that in another way somehow? |
I have created a 3.4 vm. It is linked as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me!
As previously discussed, the NEST repository on dockerhub is now automatically kept up to date again. The badge automatically links to the latest stable version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is a pressing reason why we should not link to dockerhub anymore, I'd put the link back in.
The other changes look fine to me.
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! LGTM! 👍
This PR prepares the badges for the new version 3.4. This concerns the docker image and the virtual application image. For both, the version has to be changed manually.
All other badges should update themselves automatically.