Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx-mermaid extension and update userdoc workflow #2603

Merged
merged 34 commits into from
Sep 11, 2023

Conversation

jessica-mitchell
Copy link
Contributor

This PR adds the mermaid extension for Sphinx so sequence diagrams can be build with mermaid syntax.
See kernel.html for example.

@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Feb 3, 2023
@jessica-mitchell jessica-mitchell added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: User Interface Users may need to change their code due to changes in function calls labels Feb 3, 2023
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is really a useful extension.

doc/htmldoc/conf.py Outdated Show resolved Hide resolved
@jessica-mitchell jessica-mitchell requested review from JanVogelsang and removed request for med-ayssar February 28, 2023 12:35
Copy link
Contributor

@JanVogelsang JanVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steffen's comment sounds plausible (also after taking a quick look at the spinx-mermaid installation guide), apart from that this is a nice addition that I hope we can use a lot to make the usually boring technical documentation much more visual, as an example.

@github-actions
Copy link

github-actions bot commented May 2, 2023

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 2, 2023
@jessica-mitchell jessica-mitchell removed the stale Automatic marker for inactivity, please have another look here label Jun 2, 2023
@terhorstd terhorstd moved this from In progress to Review in Documentation Jun 27, 2023
@jougs jougs changed the base branch from add-technical-docs to master August 8, 2023 12:11
@jessica-mitchell jessica-mitchell removed the I: User Interface Users may need to change their code due to changes in function calls label Aug 15, 2023
@jessica-mitchell
Copy link
Contributor Author

See new documentation workflow output here

@jessica-mitchell jessica-mitchell changed the title Add sphinx-mermaid extension Add sphinx-mermaid extension and update userdoc workflow Aug 30, 2023
@jessica-mitchell jessica-mitchell requested review from steffengraber and removed request for terhorstd September 11, 2023 09:06
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jessica-mitchell jessica-mitchell merged commit 4cf76ce into nest:master Sep 11, 2023
20 checks passed
Documentation automation moved this from Review to Done Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants