Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-picked changes to add userdict in PyNEST #2607

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Cherry-picked changes to add userdict in PyNEST #2607

merged 3 commits into from
Feb 13, 2023

Conversation

terhorstd
Copy link
Contributor

@terhorstd terhorstd commented Feb 8, 2023 •
edited

These changes pull important changes of #2584 for the userdict into the release branch.
To be discussed in release team.

@terhorstd terhorstd changed the title Cherry-picked changes of 3.4 develop userdict pick Cherry-picked changes of #2584 Feb 8, 2023
@terhorstd terhorstd added the I: User Interface Users may need to change their code due to changes in function calls label Feb 8, 2023
@terhorstd terhorstd requested a review from jougs February 8, 2023 12:03
@terhorstd terhorstd added T: Enhancement New functionality, model or documentation S: High Should be handled next labels Feb 8, 2023
@terhorstd terhorstd marked this pull request as draft February 8, 2023 18:08
jougs
jougs approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jougs jougs marked this pull request as ready for review February 13, 2023 13:32
@terhorstd terhorstd changed the title Cherry-picked changes of #2584 Cherry-picked changes to add userdict in PyNEST Feb 13, 2023
@terhorstd terhorstd merged commit 1410662 into nest:3.4-develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: User Interface Users may need to change their code due to changes in function calls S: High Should be handled next T: Enhancement New functionality, model or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terhorstd @jougs @babsey