Make get_thread virtual in Node class #2611
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_thread
function in theNode
class is not virtual, which makes the implementation of the function in theProxyNode
class useless. Mainly, theget_thread
function in theProxyNode
class will never be called, as we always have a pointer ofNode
type pointing to the proxy instance.My suggested change is to make the function virtual and remove the implementation from the
ProxyNode
.