Correctly build connection infrastructure in GetConnections also when secondary events in use #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
nicolossus
approved these changes
Feb 19, 2023
med-ayssar
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2614 with a straightforward solution:
update_delay_extrema_()andcheck_wfr_use()are now called beforeupdate_connection_infrastructure()also when the connection infrastructure is built byget_connections(). This is necessary because if no nodes or connections are added between aGetConnectionsand aSimulatecall, the infrastructure built byget_connections()is used. This requires information about the data size in secondary events, which again depends onmin_delay.PEP8 fixes in two unrelated files because they were detected by check_code_style.
This entire process needs to be refactored at a later stage, this is just a bug fix.