Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing well-proven and therefore outdated asserts #2616

Merged
merged 7 commits into from
Mar 9, 2023
Merged

Removing well-proven and therefore outdated asserts #2616

merged 7 commits into from
Mar 9, 2023

Conversation

JanVogelsang
Copy link
Contributor

The asserts in the Node::update method of all models derived from Node were checking if the parameters for the requested update interval are indeed correct. These asserts are now generally seen as superfluous, as they have not been triggered in many years now.

@JanVogelsang JanVogelsang mentioned this pull request Feb 21, 2023
Merged
jougs
jougs approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions regarding the removal (and one addition!) of empty lines resulting from the changes.

models/ac_generator.cpp Outdated Show resolved Hide resolved
models/aeif_psc_delta.cpp Show resolved Hide resolved
models/amat2_psc_exp.cpp Outdated Show resolved Hide resolved
models/binary_neuron.h Outdated Show resolved Hide resolved
models/cm_default.cpp Outdated Show resolved Hide resolved
models/gif_cond_exp.cpp Outdated Show resolved Hide resolved
models/gif_cond_exp_multisynapse.cpp Outdated Show resolved Hide resolved
models/gif_cond_exp_multisynapse.cpp Outdated Show resolved Hide resolved
models/gif_pop_psc_exp.cpp Outdated Show resolved Hide resolved
models/gif_psc_exp.cpp Outdated Show resolved Hide resolved
@jougs jougs requested a review from heplesser February 21, 2023 10:42
@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 21, 2023
jougs
jougs reviewed Feb 21, 2023
View reviewed changes
models/aeif_psc_delta.cpp Outdated Show resolved Hide resolved
jougs
jougs approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks!

@gtrensch gtrensch added this to PRs in progress in Kernel via automation Feb 24, 2023
@heplesser heplesser mentioned this pull request Mar 9, 2023
Merged
heplesser
heplesser approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up!

@heplesser
Copy link
Contributor

@jougs If we have these asserts also in the extension module example, we should remove it there as well.
@clinssen @pnbabu If NESTML-generated code so far adds these asserts, I suggest you drop them.

@heplesser heplesser merged commit 6a907bf into nest:master Mar 9, 2023
Kernel automation moved this from PRs in progress to Done (PRs and issues) Mar 9, 2023
@JanVogelsang JanVogelsang deleted the removing-asserts branch March 9, 2023 22:19
@jougs
Copy link
Contributor

jougs commented Mar 10, 2023

@jougs If we have these asserts also in the extension module example, we should remove it there as well.

Good point! I just checked nest-extension-module repository and we seem to have dropped them already there.

@pnbabu pnbabu mentioned this pull request Mar 10, 2023
Closed
@pnbabu
Copy link
Contributor

pnbabu commented Mar 13, 2023

The NESTML templates also do not use these assert statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JanVogelsang @heplesser @jougs @pnbabu