Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kernel attributes ms_per_tic and tics_per_step read-only #2620

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Make kernel attributes ms_per_tic and tics_per_step read-only #2620

merged 7 commits into from
Apr 11, 2023

Conversation

nicolossus
Copy link
Member

Fixes #2619 by making the kernel attributes ms_per_tic and tics_per_step read-only.

@gtrensch gtrensch added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 24, 2023
@gtrensch gtrensch added this to PRs in progress in Kernel via automation Feb 24, 2023
med-ayssar
med-ayssar approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@med-ayssar med-ayssar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@med-ayssar med-ayssar moved this from PRs in progress to PRs approved in Kernel Apr 11, 2023
@heplesser heplesser changed the title Change unused settable kernel attributes to read-only Make kernel attributes ms_per_tic and tics_per_step read-only Apr 11, 2023
@heplesser heplesser merged commit b509baa into nest:master Apr 11, 2023
Kernel automation moved this from PRs approved to Done (PRs and issues) Apr 11, 2023
@nicolossus nicolossus deleted the fix_set_kernel_attr branch April 11, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@med-ayssar med-ayssar med-ayssar approved these changes

@JanVogelsang JanVogelsang JanVogelsang approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settable kernel parameters that are unused
5 participants
@nicolossus @med-ayssar @JanVogelsang @heplesser @gtrensch