-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance module imports in NEST Server #2632
Conversation
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some formatting issues with the new code. I'm still approving.
Pull request automatically marked stale! |
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
…tor into server-import-modules
The test failed because of NEST CI / black. Please clarify. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where my previous approval went, but I'm still happy.
@Helveg: can you please have a look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@babsey what do you think about using the stdlib AST for this parsing task?
Co-authored-by: Robin De Schepper <robin.deschepper93@gmail.com>
It looks fine. Please review! 😄 |
This PR converts environment variable
NEST_SERVER_MODULES
:NEST_SERVER_MODULES="nest,numpy as np,random from numpy"
to formatted dictionary for updating
globals
:{'nest': <module 'nest'> 'np': <module 'numpy'>, 'random': <module 'numpy.random'>}
Test it on your computer
In Bash:
In Python: